I haven't played WoW since the end of Cataclysm, so take my answer with a grain of salt.
For the melee DPS (warrior pally and dk) strength has always been the gem to stack no matter what, unless you are missing a crucial stat, like being uncapped on Hit Rating. This stat should be increased to the necessary level (is it still 8%?) to be on par for DPS.
- Blacksmithing : Extra sockets for more Red gems. Socket Bracer & Socket Gloves
- Tailoring : Only decent embroidery -> Swordguard Embroidery (-180 Critical Strike, Hit or -200 Stamina; +1,000 Attack Power)
- Leather working : Fur Lining - Strength (+320 Strength)
- Jewel Crafting : Jeweler's Facet x2 +320 Strength
- Herbalism: +480 Haste
- Engineering : Synapse Springs (+320 Strength)
- Enchanting : Enchant Ring - Greater Strength (+320 Strength)
- Inscription : Secret Tiger Fang Inscription (+320 Strength)
- Alchemy : Alchemist's Flask (+320 Strength
- Skinning: Master of Anatomy (+480 Critical Strike) /leave it to the rogues/
- Mining: Toughness (+480 Stamina) /leave it to the tanks/
My Concensus: (based on your gains, plus money-generation potential and helping out guilds)
Jewel crafting: EVERYONE USES GEMS. Period. Money to be make, all guildies benefit, and not having to buy your own gems is a huge plus (this helped gear my 2nd 85 draenei pally way faster).
Blacksmithing: Extra gem slots, and you make the appropriate type of armor for yourself. Tied with JC.
Enchanting: Everyone needs enchants and pots for maximizing DPS. Free enchants are sweet too! Tied w/ Alchemy because $money$ and guildie help, but not as focused towards your character. (you are a BElf, so maybe consider it...)
Alchemy: Everyone needs pots and enchans for maximizing DPS. Tied w/ Enchanting because $money$ and guildie help, but not as focused towards your character.
Herbalism: Gives haste which isn't optimal, but the herbs can be worth A LOT and help guildies for flasks and glyphs.
Inscription: One stat boost, and glyphs are easy/cheap to buy in most scenarios. This does help all guildies though, unlike tailoring.
Tailoring: one mod on an item and a cool mount. However your items will only benefit clothies.
Engineering: Although the gizmos and gadgets are cool (plus a mount), I feel like there is more utility for Engineering in PVP than in PVE.
Leatherworking: 1 stat boost, you don't use leather armor. NOT WORTH
I'd pick any of the top 4, but as a Belf maybe you'll lean towards Enchanting. If you want to be self-oriented, go BS + JC or BS + Ench. Helping others would be Alchemy and Enchanting. Finally, making money should be JC + Ench.
Sorry if the last part is a bit off topic, but I could finally write an answer to something I knew really well, so I thought I should give you all the options
A BElf RET PVE Pally should go BS + JC to optimize his efforts in gearing/performing better in raids.