Return to Question

I'm a bit reluctant in making a change since it may break wine. It seems that since 1.7.0 that the call to the function OpenInputDesktop has been implemented and doesn't merely create an error message.

I'm a bit reluctant in making a change since it may break wine. It seems that since 1.7.0 that the call to the function OpenInputDesktop has been implemented and doesn't merely create an error message. OpenDesktopA function returns the OpenDesktopW function which returns the open_winstation_desktop function which basically looks like what 1.7.9 and 1.7.10 has written for the OpenInputDesktop. It's more efficient not to recompile wine with the mentioned patch as it will do the same thing as is only with a smaller runtime stack. So I need to try to install firefox, flash, and unity with 1.7.10 then copy and past the updated files from a windows pc into the correct folder. If anyone has already done it please post detailed instructions and your results so I can select it as the best answer.

Edit: The forum thread mentions applying a four part patch to fix bug number 12067, however that patch is already applied to wine version 1.7.6 and newer. The current version of wine 1.7.9 has a bug that results in certain programs, like firefox, to crash at startup (firefox gives a "could not load xpcom" error). This is suppose to be fixed when 1.7.10 comes out, however 1.7.8 runs firefox quite well. Since the simple instructions on obtaining the source code for wine using git results in the 1.7.9 code, I'll wait until 1.7.10 comes out to attempt this workaround. However the forum thread replaces:

HDESK WINAPI OpenInputDesktop( DWORD flags, BOOL inherit, ACCESS_MASK access )
{
FIXME( "(%x,%i,%x): stub\n", flags, inherit, access );
SetLastError( ERROR_CALL_NOT_IMPLEMENTED );
return 0;
}

in winstation.c (in wine version 1.7.0) with

HDESK WINAPI OpenInputDesktop( DWORD flags, BOOL inherit, ACCESS_MASK access )
{
return CreateDesktopA("Desktop", 0, 0, flags, access, 0);
}

However, in the winstation.c file in 1.7.9 it's

HDESK WINAPI OpenInputDesktop( DWORD flags, BOOL inherit, ACCESS_MASK access )
{
    HANDLE ret = 0;

    TRACE( "(%x,%i,%x)\n", flags, inherit, access );

    if (flags)
        FIXME( "partial stub flags %08x\n", flags );

    SERVER_START_REQ( open_input_desktop )
    {
        req->flags      = flags;
        req->access     = access;
        req->attributes = inherit ? OBJ_INHERIT : 0;
        if (!wine_server_call_err( req )) ret = wine_server_ptr_handle( reply->handle );
    }
    SERVER_END_REQ;

    return ret;
}

I'm a bit reluctant in making a change since it may break wine. It seems that since 1.7.0 that the call to the function OpenInputDesktop has been implemented and doesn't merely create an error message.